Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add typing support to regex-related adjudicators #1484

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from
Draft

chore: add typing support to regex-related adjudicators #1484

wants to merge 56 commits into from
+1,223 −980

Conversation

samayer12
Copy link
Collaborator

@samayer12 samayer12 commented Nov 22, 2024 •
edited
Loading

Description

This PR adds typing support for regex-related adjudicators. Merge this in after #1402.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Relates to #1397, #1402

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@samayer12
Create full mocks of AdmissionRequest<KubernetesObject>
1137b84
@samayer12
Add return type to Admission Request adjudicators
9546791
@samayer12
Address potentially undefined input to adjudicator
5d673d5
@samayer12
Add funciton return types
12c8c4a
@samayer12
Use consistent enum property names
cc3e810
@samayer12
Reworking types to remove typescript warnings so that I can actually …
d94543d 
…run tests
@samayer12
Work on resolving typing issues by using actual objects instead of pa…
a169536 
…rtials
@samayer12
use explicit imports in test file
8300b37
@samayer12
Fix failing tests in bindingadjudicator
bf38e38
@samayer12
tidy test exports, add typing, get passing tests
984660f
@samayer12
Merge branch 'main' into 1397-type-adjudicators
ecdd130
@samayer12
Add typing to mismatchedEvent()
f5c3a8d
@samayer12
Merge branch 'main' into 1397-type-adjudicators
2a0c025
@samayer12
Update imports
e7f9a5b
@samayer12
Remove obsolete test cases now that we have typing support
19a7dcd
@samayer12
Remove undefined return type on definedName()
1eb7cde
@samayer12
Remove obsolete test cases now that we use typing, manage typing for …
9aa94e9 
…regexes
@samayer12
Update imports
6fb930a
@samayer12
Merge branch 'main' into 1397-type-adjudicators
e7a2a86
@samayer12
Use regexes in test data to match typing
4c78fe0
@samayer12
Update test case to handle typing with a null test case
dd2f84d
@samayer12
Resolve test failure for mismatchedNamespaceRegex()
eaf481f
@samayer12
Merge branch 'main' into 1397-type-adjudicators
b790be3
@samayer12
Merge branch 'main' into 1397-type-adjudicators
d7da7cf
@samayer12
Move default test objects to central location
25081c2
@samayer12
Use defaultTestObjects in bindingAdjudicators.test.ts
5cc5667
@samayer12
Centralize more default test values
aa24a30
@samayer12
Merge branch 'main' into 1397-type-adjudicators
dfa4eee
@samayer12
Undo type coversion to RexExp, use string
2bdad5c
@samayer12
Remove unecessary message output sanitization
e08e896
@samayer12
Rearrange import and managed regex usage in tests
786c1a2
@samayer12
Move filesystem helper to specific file
9cc9267
@samayer12
Remove a test case obviated by the use of typing
a0dab61
@samayer12
Remove kfc mock
8bbcfd1
@samayer12
Use it() instead of test() to match domain-driven test naming style
6ca317b
@samayer12
Rewrite test using full objects and it.each()
909e890
@samayer12
Remove unnecessary regex edge case now that we use typing
937ce19
@samayer12
Update regex to match test condition
a98e0df
@samayer12
Restructure test format
5a0753d
@samayer12
Restructure name equality test
d983481
@samayer12
Remove mockK8s.mockImplementation()
d887b53
@samayer12
Restructure test
2e44cc9
@samayer12
Put related tests into a describe() block
5ac5159
@samayer12
Extract large function to new file
7c2ae10
@samayer12
Remove mocks and set return type
7434ce8
@samayer12
Update import from cli
172ebf4
@samayer12
Update imports
ac8aa24
@samayer12
Merge branch 'main' into 1397-type-adjudicators
1a4e7dd
@samayer12
Update imports after file move
06ea6cc
@samayer12
Move some helper functions to deploymentChecks
0eb3f1e
@samayer12
Remove file restructure for next commit
cb1d7bb
@samayer12
Merge branch '1397-split-helpers' into 1397-type-adjudicators
7f98a9c
@samayer12
Merge branch 'main' into 1397-type-adjudicators
8ecce94
@samayer12
Merge branch 'main' into 1397-type-adjudicators
70c1178
@samayer12
Undo regexp work to revisit on a separate PR
257c4b8
@samayer12
Revert "Undo regexp work to revisit on a separate PR"
7f1bbec 
This reverts commit 257c4b8.
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 89.87342% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.65%. Comparing base (2da08c2) to head (7f1bbec).

Files with missing lines Patch % Lines
src/lib/capability.ts 0.00% 4 Missing ⚠️
src/lib/filter/adjudicators.ts 90.47% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   78.56%   78.65%   +0.09%     
==========================================
  Files          38       39       +1     
  Lines        1717     1743      +26     
  Branches      410      418       +8     
==========================================
+ Hits         1349     1371      +22     
- Misses        339      370      +31     
+ Partials       29        2      -27
Files with missing lines Coverage Δ
src/lib/filter/adjudicators/defaultTestObjects.ts 100.00% <100.00%> (ø)
src/lib/filter/filter.ts 97.77% <100.00%> (+0.27%) ⬆️
src/lib/helpers.ts 97.93% <100.00%> (-0.03%) ⬇️
src/lib/capability.ts 94.90% <0.00%> (ø)
src/lib/filter/adjudicators.ts 97.10% <90.47%> (-2.90%) ⬇️

... and 7 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Pepr Project Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samayer12